.github: Update the style checker action for CheriBSD #2067
Conversation
|
Actual testing of this is over in a child PR against this branch here: bsdjhb#1 |
bsdjhb
force-pushed
the
disable_style
branch
2 times, most recently
from
29491a2 to
c3ae5df
Compare
If you add "::error file=foo/bar.c:line=123:" before the error message, it will appear inline. Sponsored by: Netflix (cherry picked from commit 0949b23)
Change the : between file and line to a ,. This should fix this... Sponsored by: Netflix (cherry picked from commit c2f5306)
Remove extra space... Sponsored by: Netflix (cherry picked from commit ac9abe9)
Use ::error and ::warning as appropriate to give better meaning to the messages. Sponsored by: Netflix (cherry picked from commit 22d12ca)
Let's see if we can get the style issues flagged inline. Sponsored by: Netflix (cherry picked from commit 33326dd)
|
This cherry picks several fixes back from FreeBSD to add You can see a sample of the per-file annotations it adds over at https://github.com/bsdjhb/cheribsd/pull/1/files Note that it runs the checks on each commit, so if you "fix" a style bug in a later commit, you still end up with an annotation at the original location for the bug in the first commit. |
|
I looked btw and the clang-format action we use in the disabled clang-format check doesn't support GitHub annotations (I would have tried to fix it to do so otherwise). I think we should probably just remove the clang-format check if we adopt the changes in the PR. |
bsdjhb
changed the title
- Run for PRs against dev instead of main. - Make the check always succeed but still add annotations. - Check the style of the total diff instead of each patch on the branch.
|
Now updated to only run the style check against the final diff so if a bug gets "fixed" in the middle it doesn't get annotated. |
This is very expensive to run against merges from dev to main. Even
for PRs against dev we would only want it to be advisory (and wouldn't
want it for upstream FreeBSD merge PRs).